Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tune-up #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Performance tune-up #181

wants to merge 1 commit into from

Conversation

dorjesinpo
Copy link
Collaborator

  1. Increase Event (batch) size. Keep PUT soft limit
  2. Use bsls::BlockGrowth::BSLS_CONSTANT (instead of geometric) for pools
  3. Avoid mwcu::MemOutStream while validating in Cluster
  4. StorageManager::processReceiptEvent in IO thread (minus one thread switch)
  5. FileStore generates Receipt at the end of received batch processing
  6. Change FileStore storage builder size adjustemnt logic
  7. Refactor dispatcherFlush

@dorjesinpo dorjesinpo added the enhancement New feature or request label Jan 9, 2024
@dorjesinpo dorjesinpo requested a review from a team as a code owner January 9, 2024 15:24
@dorjesinpo
Performance tune-up
b5edc98 
Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
@hallfox
Copy link
Collaborator

hallfox commented Jan 23, 2024

lgtm, what performance stats does this affect?

@dorjesinpo
Copy link
Collaborator Author

lgtm, what performance stats does this affect?

This affects latencies in the (capmon) tests with multiple queues in the same cluster (cluster thread is a bottleneck)

@dorjesinpo dorjesinpo mentioned this pull request Jul 25, 2024
Merged
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Aug 26, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 189 of commit b5edc98 has completed with FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmq-oss-ci bmq-oss-ci[bot] bmq-oss-ci[bot] left review comments

@quarter-note quarter-note Awaiting requested review from quarter-note

At least 1 approving review is required to merge this pull request.

Assignees

@quarter-note quarter-note

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorjesinpo @hallfox @quarter-note